Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cronet_http version to ^1.0.0 #2082

Merged
merged 2 commits into from
Dec 30, 2023
Merged

Conversation

amondnet
Copy link
Contributor

@amondnet amondnet commented Dec 29, 2023

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

dart-lang/http#1087

@amondnet amondnet requested a review from a team as a code owner December 29, 2023 06:31
@@ -7,7 +7,6 @@

> Note: This uses the native http implementation on macOS, iOS and Android.
> Other platforms still use the Dart http stack.
> Please keep in mind that Android is still considered experimental.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Signed-off-by: Jonas Uekötter <ueman@users.noreply.github.com>
Copy link
Contributor

@ueman ueman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ueman ueman added this pull request to the merge queue Dec 30, 2023
Merged via the queue into cfug:main with commit 1524ae5 Dec 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants